[PATCH] D38486: [PPC] Implement the heuristic to choose between a X-Form VSX ld/st vs a X-Form FP ld/st.

[Tony Jiang via Phabricator via llvm-commits]

jtony added inline comments.


================
Comment at: test/CodeGen/PowerPC/build-vector-tests.ll:3511
 ; P9LE-NEXT: blr
-; P8BE: lxsspx
-; P8BE: lxsspx
+; P8BE: lfs
+; P8BE: lfs
----------------
nemanjai wrote:
> Is this just matching because we're emitting `lfsx`? I really don't see anything in this patch that can convert an X-Form load to a D-Form load. If it is indeed a D-Form we're emitting here, please respond to this comment as to how this is happening.
> Furthermore, if we're converting this to a D-Form here, explain why we're not doing the same with the `lxsdx` -> `lfdx` change above.
This has been fixed by the new patch. It is caused by not guarding the new Pseudo instructions with proper predicates: HasP8Vector and AddedComplexity=400.


https://reviews.llvm.org/D38486