[PATCH] D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelector.h:124
+  /// - SizeInBits - The size of the pointer value in bits.
+  GIM_CheckPointerToAny,
   /// Check the register bank for the specified operand
----------------
Doesn't the pointer size depend on the address space?
Thus, given we specific the size this is not really any address space, isn't it?

Basically what I am saying is either don't put the size or change the name of the operator.
BTW, shouldn't we already check the size when checking the type?


================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:247
     }
-
+    case GIM_CheckPointerToAny: {
+      int64_t InsnID = MatchTable[CurrentIdx++];
----------------
Could you add a tablegen test case for this operator?


https://reviews.llvm.org/D37457