[PATCH] D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 12:35:15 PDT 2017


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Looks fine with one comment:
Do you think we need a new opcode in the state machine for that?

We could have reused ComplexRender with an additional parameter and use -1 to mean render all of them.
For the sake of optimization, the current patch is actually better, but in terms of simplicity I wonder.

Feel free to commit as is. That was just my 2c :).


https://reviews.llvm.org/D37456





More information about the llvm-commits mailing list