[PATCH] D38128: Handle COPYs of physregs better (regalloc hints)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/CodeGen/ARM/struct_byval_arm_t1_t2.ll:125
   define void @test_A_8() {
-;ARM:         vld1.32 {d{{[0-9]+}}}, [r{{.*}}]!
+;ARM:         vld1.32 {d{{[0-9]+}}}, [lr]!
 
----------------
A more general regex would be better here; just delete the r.  (Same for other places in this file.)


================
Comment at: test/CodeGen/ARM/swifterror.ll:350
+; CHECK-APPLE: mov r0, r8
+; CHECK-APPLE: cmp r0, #0
 ; Access part of the error object and save it to error_ref
----------------
This is... not really great.  I mean, it's the same number of instructions, but you're increasing the latency by making the cmp refer to r0 rather than r8.  Do you know why this is happening?


https://reviews.llvm.org/D38128