[PATCH] D36691: [AsmParser] Add DiagnosticString to register classes in tablegen

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 02:29:09 PDT 2017


olista01 added inline comments.


================
Comment at: llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp:2274
+  OS << "}\n\n";
+}
+
----------------
RKSimon wrote:
> @olista01 We're seeing "switch statement contains 'default' but no 'case' labels" warnings (and we build with Werror.....).
> 
> Please can you update this so that it just returns MCTargetAsmParser::Match_InvalidOperand if there are no regclass entries?
Should be fixed by https://reviews.llvm.org/rL315571.


Repository:
  rL LLVM

https://reviews.llvm.org/D36691





More information about the llvm-commits mailing list