[PATCH] D38239: [ELF] - Define linkerscript symbols early.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.cpp:128-130
+  // Context is unavailable when we call this method to early define symbols.
+  // There is nothing to do here if symbol already exist.
+  if (!Ctx && B)
----------------
ruiu wrote:
> You shouldn't use Ctx in this function. Basically, you shouldn't use Ctx as long as you can avoid it. This is important because adding a use of Ctx = more dependencies you will have.
Ok, I introduced `DefineOnly` argument instead.


https://reviews.llvm.org/D38239