[PATCH] D38830: [DWARF] Fix bad comparator in sortGlobalExprs.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Thanks! Since for the testcase only global variables are interesting, you should be able to strip out everything from the IR that is not a global variable and not reachable via a !DIGlobalVariable metadata node. You can probably just run delta on the input (especially if you insert extra newlines after each element in a DIArray (`!{!1, !2}`).



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:514
+              if (!A.Expr || !B.Expr)
+                return !!B.Expr;
+              auto FragmentA = A.Expr->getFragmentInfo();
----------------
Does `return !A.Expr` achieve the same thing and is easier to read?


Repository:
  rL LLVM

https://reviews.llvm.org/D38830