[PATCH] D38828: lld: Reorder dependent libraries alphabetically

[Rafael Avila de Espindola via llvm-commits]

LGTM

NAKAMURA Takumi via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> chapuni created this revision.
> Herald added subscribers: mgorny, emaste.
>
> Although it is trivial change, I am afraid if it would be intentional, like performance improvements. May I commit it?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D38828
>
> Files:
>   lld/trunk/COFF/CMakeLists.txt
>   lld/trunk/ELF/CMakeLists.txt
>   lld/trunk/MinGW/CMakeLists.txt
>   lld/trunk/lib/Driver/CMakeLists.txt
>   lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
>   lld/trunk/tools/lld/CMakeLists.txt
>
>
> Index: lld/trunk/tools/lld/CMakeLists.txt
> ===================================================================
> --- lld/trunk/tools/lld/CMakeLists.txt
> +++ lld/trunk/tools/lld/CMakeLists.txt
> @@ -7,8 +7,8 @@
>    )
>  
>  target_link_libraries(lld
> -  lldDriver
>    lldCOFF
> +  lldDriver
>    lldELF
>    lldMinGW
>    )
> Index: lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> ===================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> +++ lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> @@ -21,9 +21,9 @@
>  
>    LINK_COMPONENTS
>      DebugInfoDWARF
> +    Demangle
>      Object
>      Support
> -    Demangle
>  
>    LINK_LIBS
>      lldCore
> Index: lld/trunk/lib/Driver/CMakeLists.txt
> ===================================================================
> --- lld/trunk/lib/Driver/CMakeLists.txt
> +++ lld/trunk/lib/Driver/CMakeLists.txt
> @@ -14,8 +14,8 @@
>      Support
>  
>    LINK_LIBS
> -    lldMachO
>      lldCore
> +    lldMachO
>      lldReaderWriter
>      lldYAML
>    )
> Index: lld/trunk/MinGW/CMakeLists.txt
> ===================================================================
> --- lld/trunk/MinGW/CMakeLists.txt
> +++ lld/trunk/MinGW/CMakeLists.txt
> @@ -10,8 +10,8 @@
>    Driver.cpp
>  
>    LINK_COMPONENTS
> -  Support
>    Option
> +  Support
>  
>    LINK_LIBS
>    lldCOFF
> Index: lld/trunk/ELF/CMakeLists.txt
> ===================================================================
> --- lld/trunk/ELF/CMakeLists.txt
> +++ lld/trunk/ELF/CMakeLists.txt
> @@ -57,10 +57,10 @@
>    IPO
>    Linker
>    LTO
> +  MC
>    Object
>    Option
>    Passes
> -  MC
>    Support
>    Target
>    TransformUtils
> Index: lld/trunk/COFF/CMakeLists.txt
> ===================================================================
> --- lld/trunk/COFF/CMakeLists.txt
> +++ lld/trunk/COFF/CMakeLists.txt
> @@ -31,14 +31,14 @@
>    DebugInfoCodeView
>    DebugInfoMSF
>    DebugInfoPDB
> -  LTO
>    LibDriver
> -  Object
> +  LTO
>    MC
>    MCDisassembler
> -  Target
> +  Object
>    Option
>    Support
> +  Target
>    WindowsManifest
>  
>    LINK_LIBS
>
>
> Index: lld/trunk/tools/lld/CMakeLists.txt
> ===================================================================
> --- lld/trunk/tools/lld/CMakeLists.txt
> +++ lld/trunk/tools/lld/CMakeLists.txt
> @@ -7,8 +7,8 @@
>    )
>  
>  target_link_libraries(lld
> -  lldDriver
>    lldCOFF
> +  lldDriver
>    lldELF
>    lldMinGW
>    )
> Index: lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> ===================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> +++ lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt
> @@ -21,9 +21,9 @@
>  
>    LINK_COMPONENTS
>      DebugInfoDWARF
> +    Demangle
>      Object
>      Support
> -    Demangle
>  
>    LINK_LIBS
>      lldCore
> Index: lld/trunk/lib/Driver/CMakeLists.txt
> ===================================================================
> --- lld/trunk/lib/Driver/CMakeLists.txt
> +++ lld/trunk/lib/Driver/CMakeLists.txt
> @@ -14,8 +14,8 @@
>      Support
>  
>    LINK_LIBS
> -    lldMachO
>      lldCore
> +    lldMachO
>      lldReaderWriter
>      lldYAML
>    )
> Index: lld/trunk/MinGW/CMakeLists.txt
> ===================================================================
> --- lld/trunk/MinGW/CMakeLists.txt
> +++ lld/trunk/MinGW/CMakeLists.txt
> @@ -10,8 +10,8 @@
>    Driver.cpp
>  
>    LINK_COMPONENTS
> -  Support
>    Option
> +  Support
>  
>    LINK_LIBS
>    lldCOFF
> Index: lld/trunk/ELF/CMakeLists.txt
> ===================================================================
> --- lld/trunk/ELF/CMakeLists.txt
> +++ lld/trunk/ELF/CMakeLists.txt
> @@ -57,10 +57,10 @@
>    IPO
>    Linker
>    LTO
> +  MC
>    Object
>    Option
>    Passes
> -  MC
>    Support
>    Target
>    TransformUtils
> Index: lld/trunk/COFF/CMakeLists.txt
> ===================================================================
> --- lld/trunk/COFF/CMakeLists.txt
> +++ lld/trunk/COFF/CMakeLists.txt
> @@ -31,14 +31,14 @@
>    DebugInfoCodeView
>    DebugInfoMSF
>    DebugInfoPDB
> -  LTO
>    LibDriver
> -  Object
> +  LTO
>    MC
>    MCDisassembler
> -  Target
> +  Object
>    Option
>    Support
> +  Target
>    WindowsManifest
>  
>    LINK_LIBS
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits