[PATCH] D38817: Support: Work around missing SetFileInformationByHandle on Wine
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 11 14:33:24 PDT 2017
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Support/Windows/Path.inc:417
+
+ if (EC.value() == ERROR_CALL_NOT_IMPLEMENTED) {
+ // Wine doesn't support SetFileInformationByHandle in rename_internal.
----------------
Perhaps more precise to compare `EC` against `std::error_code(ERROR_CALL_NOT_IMPLEMENTED, std::system_category())` here.
https://reviews.llvm.org/D38817
More information about the llvm-commits
mailing list