[PATCH] D38817: Support: Work around missing SetFileInformationByHandle on Wine

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lib/Support/Windows/Path.inc:436
     auto EC = rename_internal(FromHandle, To, true);
     if (!EC || EC != errc::permission_denied)
       return EC;
----------------
pcc wrote:
> Wine returns `ERROR_CALL_NOT_IMPLEMENTED` if it does not support the call to `SetFileInformationByHandle`. Would it be simpler to detect that here and try the `MoveFileEx` if it fails in that way?
Yes, that seems much nicer. Thanks!


https://reviews.llvm.org/D38817