[PATCH] D38776: [codeview] Implement FPO data assembler directives
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 11 14:19:49 PDT 2017
rnk marked an inline comment as done.
rnk added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp:307-309
+ // Each saved register is stored at an unchanging negative CFA offset.
+ for (RegSaveOffset RO : RegSaveOffsets)
+ FuncOS << printFPOReg(MRI, RO.Reg) << " $T0 " << RO.Offset << " - ^ = ";
----------------
majnemer wrote:
> Are these sorted by register? If not, you could get more string sharing if you sorted first.
The strings should be well-shared because we typically allocate CSRs in the same order in every function. I like not sorting them because then the previous FrameFunc is usually a prefix of the next FrameFunc, which you can see in the test cases here.
https://reviews.llvm.org/D38776
More information about the llvm-commits
mailing list