[PATCH] D38760: [LLD] [COFF] Add support for automatically exporting all symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/Driver.cpp:598-599
+       << "@" << E.Ordinal;
+    if (E.Sym) {
+      auto *Def = dyn_cast<Defined>(E.Sym);
+      if (Def && Def->getChunk() &&
----------------
You can combine the two lines to

  if (auto *Def = dyn_cast_or_null<Defined>(E.Sym))


https://reviews.llvm.org/D38760