[PATCH] D38815: [LLD] [COFF] Implement support for IMAGE_REL_ARM64_ADDR32NB
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 11 12:09:07 PDT 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: COFF/Chunks.cpp:226
case IMAGE_REL_ARM64_ADDR64: add64(Off, S + Config->ImageBase); break;
+ case IMAGE_REL_ARM64_ADDR32NB: add32(Off, S); break;
default:
----------------
Instead of adding at the end of the list, I'd add it after ADDR32, so that the list order doesn't look random.
https://reviews.llvm.org/D38815
More information about the llvm-commits
mailing list