[PATCH] D38645: [NVPTX] Implemented wmma intrinsics and instructions.

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/wmma.py:154
+define ${ret_ty} @test_wmma_mma_${function_suffix}(
+\t${values}) {
+; CHECK wmma.mma.${intrinsic_suffix} {{.*}}[%rd{{[0-9+]}}
----------------
jlebar wrote:
> s/values/params/?
'args' would work even better. Replaced.


================
Comment at: llvm/test/CodeGen/NVPTX/wmma.py:188
+    # Make list of all values in a,b,c
+    values = ",\n\t".join(make_wmma_slice_args(t, abcd, prefix=abcd)
+                          for abcd, t in (("a", "f16"),("b", "f16"), ("c", ctype)))
----------------
jlebar wrote:
> `test_params["values"] = ...`?
The line gets too long to split in a readable way. 


https://reviews.llvm.org/D38645