[PATCH] D38239: [ELF] - Define linkerscript symbols early.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:1041
 
+  // We want to define symbols assigned by linker script early enough,
+  // so we can version them and change attributes before normal
----------------
Remove "enough"


================
Comment at: ELF/LinkerScript.cpp:128-130
+  // Context is unavailable when we call this method to early define symbols.
+  // There is nothing to do here if symbol already exist.
+  if (!Ctx && B)
----------------
You shouldn't use Ctx in this function. Basically, you shouldn't use Ctx as long as you can avoid it. This is important because adding a use of Ctx = more dependencies you will have.


https://reviews.llvm.org/D38239