[PATCH] D38776: [codeview] Implement FPO data assembler directives

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp:264
+    switch (LLVMReg) {
+    // MSVC only seems to emit symbolic register names for EIP, EBP, and ESP,
+    // but the format seems to support more than that, so we emit them.
----------------
Comment needs to be updated now that you added more symbolic names.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp:330
+  OS.EmitIntValue(FPO->ParamsSize, 4);
+  OS.EmitIntValue(0, 4); // MaxStackSize
+  OS.EmitIntValue(FrameFuncStrTabOff, 4); // FrameFunc
----------------
I'd maybe include a comment saying that MSVC seems to always set this to 0.


https://reviews.llvm.org/D38776