[PATCH] D38735: [ScheduleDAGInstrs] fix behavior of getUnderlyingObjectsForCodeGen when no identifiable object found

[Hiroshi Inoue via Phabricator via llvm-commits]

inouehrs added a comment.

In the old implementation of `getUnderlyingObjectsForInstr` <https://github.com/llvm-mirror/llvm/blob/c19eec32627989457c78dbfd91f79c3be1b99422/lib/CodeGen/ScheduleDAGInstrs.cpp#L187-L223>, Objects vector is cleared when `getUnderlyingObjects` (and hence `GetUnderlyingObjects`) returns an unidentified object, but not cleared when `getUnderlyingObjects` returns no object.
I added boolean return value in `getUnderlyingObjectsForCodeGen` to distinguish these two cases, since it returns empty vector for both cases.

Do you mean using boolean return value also in `getUnderlyingObjectsForInstr` for consistency?


https://reviews.llvm.org/D38735