[PATCH] D38776: [codeview] Implement FPO data assembler directives

[David Majnemer via Phabricator via llvm-commits]

majnemer added a comment.

It'd also be nice to have a test showing how it interacts with stack cookies.



================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp:263-266
+    // Otherwise, get the codeview register number and print $N.
+    default:
+      OS << '$' << MRI->getCodeViewRegNum(LLVMReg);
+      break;
----------------
majnemer wrote:
> Shouldn't X86::EAX be $eax, etc?
Woah, apparently *both* work:

https://github.com/GPUOpen-Tools/CodeXL/blob/6f0aa6b42ae47028981058ccc3c505a5884d2c2e/CodeXL/Components/CpuProfiling/AMDTCpuCallstackSampling/src/StackWalker/x86/PostfixFrameEvaluator.cpp#L129
https://github.com/GPUOpen-Tools/CodeXL/blob/6f0aa6b42ae47028981058ccc3c505a5884d2c2e/CodeXL/Components/CpuProfiling/AMDTCpuCallstackSampling/src/StackWalker/x86/PostfixFrameEvaluator.cpp#L188

I guess this way is more general?


https://reviews.llvm.org/D38776