[PATCH] D38767: Make Twine's copy constructor private

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/ADT/Twine.h:176
 
+    // Copy constructor is private.  We need the copy constructor internally,
+    // but otherwise Twines are not intended to be copied.
----------------
I'd probably skip the "Copy constructor is private" - as I'm guessing that's fairly obvious from context.

& "We need" - I think it's usually better to impersonalize comments "The copy constructor is used internally but Twines are not intended to be publicly copyable." perhaps.


https://reviews.llvm.org/D38767