[PATCH] D38756: [x86] use an insert op to put one variable element into a constant of vectors

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> I tried to work-around the FP issue by creating a constant pool load, but that got a bit ugly - I had to call LowerConstantPool() to create a legal vector of constants.

Yes, it's a little ugly, but it's self-contained.  I don't have a better suggestion.

> but that caused an inf-loop with the opposite DAGCombiner transform that sticks the insertelement back into the BV.

DAGCombine prefers to simplify the other way to eliminate chains of inserts... I think you would run into serious problems trying to change that.


https://reviews.llvm.org/D38756