[PATCH] D38697: [SLP] Fix for PR32086: Count InsertElementInstr of the same elements as shuffle.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:658
   /// context means the creation of vectors from a group of scalars.
-  int getGatherCost(Type *Ty);
+  int getGatherCost(Type *Ty, const DenseSet<unsigned> &ShuffledIndicies);
 
----------------
Spelling mistake - ShuffledIndices not ShuffledIndicies


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1492
+      continue;
+    UniqueValues.emplace_back(V);
+  }
----------------
```
if (Res.second)
   UniqueValues.emplace_back(V);
```


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2003
+  int ReuseShuffleCost = 0;
+  if (ReuseShuffleNumbers) {
+    ReuseShuffleCost =
----------------
Is this better?
```
if (!E->ReuseShuffleIndicies.empty())
```


https://reviews.llvm.org/D38697