[PATCH] D38715: Support: On Windows, use CreateFileW to delete files in sys::fs::remove().
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 10 11:26:30 PDT 2017
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Can you add a comment indicating what the first two flags are used for? They aren't very common, so it might help someone in the future understand what's going on.
Also maybe a top-level comment indicating why we're doing things this way instead of the old way.
Don't need to re-upload, lgtm already.
https://reviews.llvm.org/D38715
More information about the llvm-commits
mailing list