[PATCH] D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

Is it a good idea to support cache pruning in the gold plugin? As I mentioned in https://reviews.llvm.org/D31063 there are some unavoidable race conditions due to limitations in the plugin API.



================
Comment at: llvm/trunk/tools/gold/gold-plugin.cpp:980
+  // Prune cache
+  if (!options::cache_policy.empty()) {
+    CachePruningPolicy policy = check(parseCachePruningPolicy(options::cache_policy));
----------------
I think this should check `cache_dir`, not `cache_policy`.


Repository:
  rL LLVM

https://reviews.llvm.org/D37993