[PATCH] D38200: [GISel]: Process new insts to legalize in the order they were created

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 09:29:03 PDT 2017


qcolombet added a comment.

> I'm a bit confused by the above. Should we allow legalization to look at other instructions, or should we not?

I believe we shouldn't allow to look at other instructions. I am guessing we need to do that to perform combines at legalization time and I think we shouldn't go in that direction. I would rather have the combines be a separate pass. I.e., we are not taking the same approach as SelectionDAG here.

Aditya, is this really needed to perform legalization?


Repository:
  rL LLVM

https://reviews.llvm.org/D38200





More information about the llvm-commits mailing list