[PATCH] D38703: [lit] Only enable LSan on darwin when clang supports it

[Zachary Turner via Phabricator via llvm-commits]

zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: utils/lit/lit/llvm/config.py:207
+        if not clang:
+            self.lit_config.warning("config.host_cxx is unset")
+            return False
----------------
Can you improve this warning to say why it's needed?  Something like `"config.host_cxx is unset but test suite is configured to use sanitizers.`


================
Comment at: utils/lit/lit/llvm/config.py:213-214
+        if not 'clang' in version_string:
+            self.lit_config.warning(
+                "compiler '%s' does not appear to be clang" % clang_binary)
+            return False
----------------
Same here.  `compiler '%s' does not appear to be clang, but test suite is configured to use sanitizers.`


https://reviews.llvm.org/D38703