[PATCH] D36508: [ELF] - Linkerscript: Add `~` as separate math token.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 10 09:08:55 PDT 2017
>> ruiu added a comment.
>>
>> Ah, sorry, I missed the first line of your last comment.
>>
>>
>>
>> ================
>> Comment at: ELF/ScriptLexer.cpp:171
>> static std::vector<StringRef> tokenizeExpr(StringRef S) {
>> - StringRef Ops = "+-*/:"; // List of operators
>> + StringRef Ops = "+-*/:~"; // List of operators
>>
>> ----------------
>> I'd think you should spend a little more time on each patch. Apparently, you need to update the following comment that assumes `+-*/` >is a list of operators.
>
>I would probably delete the second comment on line 177. Duplicated
>comments are very easy to get out of sync.
>
>Cheers,
>Rafael
Yep. Or we can chang it:
>From "// Split S with +-*/ as separators." to "// Split S with operators as separators.".
George.
More information about the llvm-commits
mailing list