[PATCH] D38722: Added Remarks for Loop Versioning LICM Pass

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

Thanks for working on this!

Please include diff context for the change.  See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface how to generate the diff.



================
Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:410
+                                 CurLoop->getStartLoc(), CurLoop->getHeader())
+        << "Runtime checks are more than threshold !!\n");
     return false;
----------------
It's usually useful to output the actual numbers.  See how we do that in Inliner.cpp where we include the cost and the threshold.

Also please use the new closure API with emit.  Again, see the inliner or https://reviews.llvm.org/D38285.


https://reviews.llvm.org/D38722