[compiler-rt] r315320 - [sanitizer] Revert D38706

[Kostya Kortchinsky via llvm-commits]

Author: cryptoad
Date: Tue Oct 10 08:35:11 2017
New Revision: 315320

URL: http://llvm.org/viewvc/llvm-project?rev=315320&view=rev
Log:
[sanitizer] Revert D38706

Summary:
D38706 breaks tsan and the nolibc build.
Reverting while working on a fix.

Reviewers: alekseyshl

Subscribers: kubamracek, mgorny, llvm-commits

Differential Revision: https://reviews.llvm.org/D38739

Removed:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.cc
Modified:
    compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.h

Modified: compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt?rev=315320&r1=315319&r2=315320&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt Tue Oct 10 08:35:11 2017
@@ -3,7 +3,6 @@
 
 set(SANITIZER_SOURCES_NOTERMINATION
   sanitizer_allocator.cc
-  sanitizer_allocator_checks.cc
   sanitizer_common.cc
   sanitizer_deadlock_detector1.cc
   sanitizer_deadlock_detector2.cc

Removed: compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.cc?rev=315319&view=auto
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.cc (removed)
@@ -1,23 +0,0 @@
-//===-- sanitizer_allocator_checks.cc ---------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-//
-// Various checks shared between ThreadSanitizer, MemorySanitizer, etc. memory
-// allocators.
-//
-//===----------------------------------------------------------------------===//
-
-#include "sanitizer_errno.h"
-
-namespace __sanitizer {
-
-void SetErrnoToENOMEM() {
-  errno = errno_ENOMEM;
-}
-
-} // namespace __sanitizer

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.h?rev=315320&r1=315319&r2=315320&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.h (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_allocator_checks.h Tue Oct 10 08:35:11 2017
@@ -15,22 +15,17 @@
 #ifndef SANITIZER_ALLOCATOR_CHECKS_H
 #define SANITIZER_ALLOCATOR_CHECKS_H
 
+#include "sanitizer_errno.h"
 #include "sanitizer_internal_defs.h"
 #include "sanitizer_common.h"
 #include "sanitizer_platform.h"
 
 namespace __sanitizer {
 
-// The following is defined in a separate compilation unit to avoid pulling in
-// sanitizer_errno.h in this header, which leads to conflicts when other system
-// headers include errno.h. This is usually the result of an unlikely event,
-// and as such we do not care as much about having it inlined.
-void SetErrnoToENOMEM();
-
 // A common errno setting logic shared by almost all sanitizer allocator APIs.
 INLINE void *SetErrnoOnNull(void *ptr) {
   if (UNLIKELY(!ptr))
-    SetErrnoToENOMEM();
+    errno = errno_ENOMEM;
   return ptr;
 }