[PATCH] D38721: [ELF] - Teach LLD to report line numbers for data symbols.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 07:26:02 PDT 2017


dblaikie added inline comments.


================
Comment at: ELF/InputFiles.cpp:91
+    DWARFDie Die = {CU, &Entry};
+    for (DWARFDie Child = Die.getFirstChild(); Child; Child = Child.getSibling()) {
+      // Skip all tags that are not variables.
----------------
Why are the children being visited here? the 'dies' collection in the outer loop should visit all the DIEs, right?


https://reviews.llvm.org/D38721





More information about the llvm-commits mailing list