[PATCH] D29438: [XRay] Probe for CPU features that XRay needs

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked an inline comment as done.
dberris added inline comments.


================
Comment at: compiler-rt/trunk/lib/xray/xray_x86_64.cc:211-213
+  // EDX. That's 0x8000000 (or 1u << 26).
+  __get_cpuid(0x80000001, &EAX, &EBX, &ECX, &EDX);
+  if (!(EDX & (1u << 26))) {
----------------
jbulow wrote:
> 1u<<26 == 0x4000000
> 
> Changing 26 to 27 solves this problem when running with xray enabled:
> 
> 
> ```
> ==20069==Missing rdtscp support.
> 
> ```
> 
> 
Oh wow, that's embarrassing! Good catch, thanks @jbulow!


Repository:
  rL LLVM

https://reviews.llvm.org/D29438