[PATCH] D38128: Handle COPYs of physregs better (regalloc hints)

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 04:41:28 PDT 2017


mstorsjo added a comment.

I checked the test that I had written (`CodeGen/AArch64/win64_vararg.ll`) and found one issue.



================
Comment at: test/CodeGen/AArch64/win64_vararg.ll:182
 ; CHECK: bl      __stdio_common_vsprintf
-; CHECK: mov     sp, x23
+; CHECK: mov     sp, [[REG2]]
 ; CHECK: sub     sp, x29, #48
----------------
This part looks ok


================
Comment at: test/CodeGen/AArch64/win64_vararg.ll:268
-; CHECK: mov     w4,  w9
-; CHECK: mov     w6,  w8
 ; CHECK: str     x30, [sp, #16]
----------------
This part seems to be broken or missing lines in the updated test; the test must check that w2 gets what was in w1 originally, w4 gets what was in w2 and w6 gets what was in w3.


https://reviews.llvm.org/D38128





More information about the llvm-commits mailing list