[PATCH] D38712: [ELF] Try to not emit weird diagnostics on undefined symbols

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 19:43:02 PDT 2017


davide added inline comments.


================
Comment at: ELF/Relocations.cpp:865-866
 
+      // If we report an undefined, and we have an error, go on.
+      if (ErrorCount)
+        continue;
----------------
ruiu wrote:
> Can you just continue without checking for ErrorCount?
Not quite :(

********************
Testing Time: 2.76s
********************
Failing Tests (36):


https://reviews.llvm.org/D38712





More information about the llvm-commits mailing list