[llvm] r314915 - [test] Fix append_path in the empty case

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 17:17:33 PDT 2017


On Mon, Oct 9, 2017 at 3:09 PM, Francis Ricci <francisjricci at gmail.com> wrote:
> Hmm, ":" should definitely be a valid separator, unless some extra
> quotes are getting added in somewhere that shouldn't be. What's the
> actual ASAN_OPTIONS string you're seeing?

Like I mentioned above, I don't see ":" handling in ASAN_OPTIONS env
parse code. Looking at parse_flags() in
lib/sanitizer_common/sanitizer_flag_parser.cc, it looks to me like the
only acceptable separator is a whitespace. But I might be missing
something. My question is: where did you find that ":" is valid?

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc


More information about the llvm-commits mailing list