[llvm] r315248 - [llvm-rc] Try again to fix errors on big endian systems.
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 9 15:59:40 PDT 2017
Author: zturner
Date: Mon Oct 9 15:59:40 2017
New Revision: 315248
URL: http://llvm.org/viewvc/llvm-project?rev=315248&view=rev
Log:
[llvm-rc] Try again to fix errors on big endian systems.
Modified:
llvm/trunk/tools/llvm-rc/ResourceFileWriter.cpp
Modified: llvm/trunk/tools/llvm-rc/ResourceFileWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-rc/ResourceFileWriter.cpp?rev=315248&r1=315247&r2=315248&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-rc/ResourceFileWriter.cpp (original)
+++ llvm/trunk/tools/llvm-rc/ResourceFileWriter.cpp Mon Oct 9 15:59:40 2017
@@ -166,9 +166,7 @@ static Error processString(StringRef Str
}
}
- // Make sure to write little-endian strings, regardless of the host
- // byte-order.
- Result.push_back(endian::byte_swap(Char, little));
+ Result.push_back(Char);
return Error::success();
};
@@ -1131,7 +1129,7 @@ Error ResourceFileWriter::writeMenuDefin
Error ResourceFileWriter::writeMenuBody(const RCResource *Base) {
// At first, MENUHEADER structure. In fact, these are two WORDs equal to 0.
// Ref: msdn.microsoft.com/en-us/library/windows/desktop/ms648018.aspx
- writeObject<uint32_t>(0);
+ writeInt<uint32_t>(0);
return writeMenuDefinitionList(cast<MenuResource>(Base)->Elements);
}
@@ -1250,9 +1248,9 @@ Error ResourceFileWriter::writeVersionIn
uint64_t LengthLoc;
if (OutputHeader) {
- LengthLoc = writeObject<uint16_t>(0);
- writeObject<uint16_t>(0);
- writeObject<uint16_t>(true);
+ LengthLoc = writeInt<uint16_t>(0);
+ writeInt<uint16_t>(0);
+ writeInt<uint16_t>(1); // true
RETURN_IF_ERROR(writeCString(Blk.Name));
padStream(sizeof(uint32_t));
}
@@ -1304,9 +1302,9 @@ Error ResourceFileWriter::writeVersionIn
return createError(Twine("VALUE ") + Val.Key +
" cannot contain both strings and integers");
- auto LengthLoc = writeObject<uint16_t>(0);
- auto ValLengthLoc = writeObject<uint16_t>(0);
- writeObject<uint16_t>(HasStrings);
+ auto LengthLoc = writeInt<uint16_t>(0);
+ auto ValLengthLoc = writeInt<uint16_t>(0);
+ writeInt<uint16_t>(HasStrings);
RETURN_IF_ERROR(writeCString(Val.Key));
padStream(sizeof(uint32_t));
More information about the llvm-commits
mailing list