[llvm] r314915 - [test] Fix append_path in the empty case

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 15:05:48 PDT 2017


On Mon, Oct 9, 2017 at 1:07 PM, Francis Ricci <francisjricci at gmail.com> wrote:
> Ahh sorry, I misread your diff. Either way, adding the extra layer of
> quoting looks fine to me - I can take care of it if you'd like, but
> you can feel free (especially since you have the ability to test
> against the broken use case)

Sure, I just want to double check first if it also works for you :-)

>>> Thanks for fixing this. However, I'm not quite sure I get part of
>>> this. Looking at parse_flags() in
>>> lib/sanitizer_common/sanitizer_flag_parser.cc, it looks to me like the
>>> separator is a whitespace. os.path.pathsep defaults to ":" on darwin,
>>> as you notice in your comment. I guess was never a issue for
>>> ASAN_OPTIONS because it had never more than one?

Any ideas on this comment above? I'm curious if your changes do
actually work for more than one option: ":" doesn't seem to be a valid
separator for ASAN_OPTIONS. Did I miss something?

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc


More information about the llvm-commits mailing list