[PATCH] D38453: [dwarfdump] Verify that unit type matches root DIE

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/trunk/include/llvm/BinaryFormat/Dwarf.h:348
+  case DW_TAG_skeleton_unit:
+  case DW_TAG_imported_unit:
+    return true;
----------------
dblaikie wrote:
> This is probably incorrect - imported_units seem to be used to import a unit into another unit, they aren't themselves a valid top-level unit. (See Figure E.6 in DWARF5 for an example of their use)
Thanks David! I sent an e-mail to the dwarf standard mailing list and the first reply confirms you are indeed correct. I've committed a fix that removes this. 


Repository:
  rL LLVM

https://reviews.llvm.org/D38453