[PATCH] D38335: [llvm-objcopy] Add support for --strip-sections to remove all section headers leaving only program headers and loadable segment data

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-sections.test:28
+#CHECK-NEXT:  Ident {
+#CHECK-NEXT:     Magic: (7F 45 4C 46)
+#CHECK-NEXT:     Class: 64-bit (0x2)
----------------
jhenderson wrote:
> FWIW, I don't think you need to check all the fields, just the section header ones, but if you think it's useful, I'm not opposed to it.
To be perfectly honest I just copy and paste the headers for %t and then make the changes that should be made so that they match what %t2 should be. So this is me just being lazy not me covering bases. I don't think it's harming anything so I'll just leave it.


Repository:
  rL LLVM

https://reviews.llvm.org/D38335