[PATCH] D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 13:21:42 PDT 2017


RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

Test case?



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:8032
+    SDValue ZeroC = DAG.getConstant(0, dl,
+                                    Subtarget.is64Bit() ? MVT::i64 : MVT::i32);
     SDValue AllZeros = DAG.getSplatBuildVector(ResVT, dl, ZeroC);
----------------
Surely you could just use DAG.getIntPtrConstant(0, dl) ?


https://reviews.llvm.org/D38689





More information about the llvm-commits mailing list