[PATCH] D36508: [ELF] - Linkerscript: Add `~` as separate math token.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 11:55:14 PDT 2017


ruiu added a comment.

Ah, sorry, I missed the first line of your last comment.



================
Comment at: ELF/ScriptLexer.cpp:171
 static std::vector<StringRef> tokenizeExpr(StringRef S) {
-  StringRef Ops = "+-*/:"; // List of operators
+  StringRef Ops = "+-*/:~"; // List of operators
 
----------------
I'd think you should spend a little more time on each patch. Apparently, you need to update the following comment that assumes `+-*/` is a list of operators.


https://reviews.llvm.org/D36508





More information about the llvm-commits mailing list