[PATCH] D37355: Add CalledValuePropagation pass

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 06:50:17 PDT 2017


dberlin added a comment.

I'm a bit confused why you use a vector instead of std::set or DenseSet. It looks like either would be better in every way?

You say " Using a vector instead of set is handy for equality testing, which the lattice value is required to implement."

But i honestly don't get it :)

Other than that (and the associated changes to merge, etc.  That could just use set_union), this looks reasonable to me.


https://reviews.llvm.org/D37355





More information about the llvm-commits mailing list