[PATCH] D38435: [SCEV] Maintain and use a loop->loop invalidation dependency

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:6567
+    SmallPtrSet<const Loop *, 8> &LoopsUsed;
+    FindUsedLoops(SmallPtrSet<const Loop *, 8> &LoopsUsed)
+        : LoopsUsed(LoopsUsed) {}
----------------
Make this `SmallPtrSetImpl` to get rid of dependency on size here?


================
Comment at: unittests/Analysis/ScalarEvolutionTest.cpp:36
+    return AR->isAffine() && AR->getLoop() == L && AR->getOperand(0) == S &&
+           AR->getOperand(0) == S;
+  return false;
----------------
Duplicating check or misprint?


https://reviews.llvm.org/D38435