[PATCH] D36706: DAGCombiner: Add form of isFPExtFree to check uses

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A few style comments, but its up to whether @efriedma and the PPC guys are happy with this change.



================
Comment at: include/llvm/Target/TargetLowering.h:2125
+  virtual bool isFPExtFree(EVT DestVT, EVT SrcVT) const {
+    assert(SrcVT.isFloatingPoint() && DestVT.isFloatingPoint());
     return false;
----------------
Add assertion message


================
Comment at: include/llvm/Target/TargetLowering.h:2133
+  virtual bool isFPExtFoldable(unsigned Opcode, EVT DestVT, EVT SrcVT) const {
+    // TODO: SrcVT may be useful.
+    assert(DestVT.isFloatingPoint() && SrcVT.isFloatingPoint());
----------------
You can drop this comment.


================
Comment at: include/llvm/Target/TargetLowering.h:2134
+    // TODO: SrcVT may be useful.
+    assert(DestVT.isFloatingPoint() && SrcVT.isFloatingPoint());
+    return isFPExtFree(DestVT, SrcVT);
----------------
Add assertion message


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:13277
+bool PPCTargetLowering::isFPExtFree(EVT DestVT, EVT SrcVT) const {
+  assert(DestVT.isFloatingPoint() && SrcVT.isFloatingPoint());
   return true;
----------------
Add assertion message


https://reviews.llvm.org/D36706