[llvm] r315146 - [X86] Update an outdated comment about SjLj
Martin Storsjo via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 6 23:00:33 PDT 2017
Author: mstorsjo
Date: Fri Oct 6 23:00:32 2017
New Revision: 315146
URL: http://llvm.org/viewvc/llvm-project?rev=315146&view=rev
Log:
[X86] Update an outdated comment about SjLj
The SjLj intrinsics in the X86 backend are intended for use with
SjLj exception handling as well, since SVN r271244.
Differential Revision: https://reviews.llvm.org/D38532
Modified:
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=315146&r1=315145&r2=315146&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Oct 6 23:00:32 2017
@@ -425,12 +425,8 @@ X86TargetLowering::X86TargetLowering(con
setOperationAction(ISD::SELECT_CC, MVT::x86mmx, Expand);
setOperationAction(ISD::EH_RETURN , MVT::Other, Custom);
- // NOTE: EH_SJLJ_SETJMP/_LONGJMP supported here is NOT intended to support
- // SjLj exception handling but a light-weight setjmp/longjmp replacement to
- // support continuation, user-level threading, and etc.. As a result, no
- // other SjLj exception interfaces are implemented and please don't build
- // your own exception handling based on them.
- // LLVM/Clang supports zero-cost DWARF exception handling.
+ // NOTE: EH_SJLJ_SETJMP/_LONGJMP are not recommended, since
+ // LLVM/Clang supports zero-cost DWARF and SEH exception handling.
setOperationAction(ISD::EH_SJLJ_SETJMP, MVT::i32, Custom);
setOperationAction(ISD::EH_SJLJ_LONGJMP, MVT::Other, Custom);
setOperationAction(ISD::EH_SJLJ_SETUP_DISPATCH, MVT::Other, Custom);
More information about the llvm-commits
mailing list