[PATCH] D38640: [WebAssembly] Narrow the scope of WebAssemblyFixFunctionBitcasts

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 16:46:45 PDT 2017


sunfish added a comment.

Is the assumption here that the eventual caller will cast the argument back to the original type?

For example, in `test_argument`, if `call_func` bitcasts the `i32 ()*` argument to `void (i32)*` before calling it, then it doesn't want a wrapper. However, if it doesn't do that cast, and just calls it as `i32 ()*`, then it does seem to need the wrapper. So I think it's a guess either way. Do you think functions doing an extra cast are more common that functions that don't?


https://reviews.llvm.org/D38640





More information about the llvm-commits mailing list