[PATCH] D38651: [llvm-rc] Have the tokenizer discard comments

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 16:23:51 PDT 2017


amccarth added inline comments.


================
Comment at: llvm/tools/llvm-rc/ResourceScriptToken.cpp:149
+void Tokenizer::skipCurrentLine() {
+  Pos = Data.find_first_of("\r\n", Pos);
+  Pos = Data.find_first_not_of("\r\n", Pos);
----------------
Does this happen after line concatenation?  If a line ends with a backslash just before the newline, then the "single-line" comment includes the next "line" as well.


https://reviews.llvm.org/D38651





More information about the llvm-commits mailing list