[PATCH] D38652: Use error() instead of warn() to report undefined symbols.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 16:11:04 PDT 2017


ruiu created this revision.

I believe the reason why we used warn() instead of error() to report
undefined symbols is because the older implementation of error() exitted
immediately. Here, we want to find as many undefined symbols as we can,
so I chose to use warn() instead of error().

Now error() does not exit immediately, so it doesn't make sense to keep
them as warnings.


https://reviews.llvm.org/D38652

Files:
  lld/COFF/Driver.cpp
  lld/COFF/SymbolTable.cpp
  lld/test/COFF/entry-inference.test
  lld/test/COFF/force.test
  lld/test/COFF/nodefaultlib.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38652.118105.patch
Type: text/x-patch
Size: 4681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171006/6e92dae2/attachment.bin>


More information about the llvm-commits mailing list