[PATCH] D38638: [MC] Suppress .Lcfi labels when emitting textual assembly

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 14:36:18 PDT 2017


Reid Kleckner via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

>  MCSymbol *MCStreamer::EmitCFICommon() {
> @@ -735,6 +735,8 @@
>  void MCStreamer::Finish() {
>    if (!DwarfFrameInfos.empty() && !DwarfFrameInfos.back().End)
>      report_fatal_error("Unfinished frame!");
> +  if (!WinFrameInfos.empty() && !WinFrameInfos.back()->End)
> +    report_fatal_error("Unfinished frame!");

This is unrelated, no?
Should we have a different error message?

This seems a bit of a hack, but the result is so much better that
LGTM. We can always try to clean it up later.

Thanks!
Rafael


More information about the llvm-commits mailing list