[PATCH] D38610: [AMDGPU] Lower enqueued blocks and generate runtime metadata

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 14:12:07 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUOpenCLEnqueuedBlockLowering.cpp:82
+      auto *AddrCast = cast<ConstantExpr>(*BitCast->user_begin());
+      auto RuntimeHandle = (F.getName() + "_runtime_handle").str();
+      auto *GV = new GlobalVariable(
----------------
This is still producing a std::string. This should be an explicit Twine, not auto


https://reviews.llvm.org/D38610





More information about the llvm-commits mailing list