[PATCH] D36706: DAGCombiner: Add form of isFPExtFree to check uses

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 12:37:39 PDT 2017


efriedma added a comment.

We should provide both the source and destination VT for any query like this... should be easy to provide even on the IR path.

But anyway, there's a difference between a free fp-extend (like on PowerPC or x87, where the value actually doesn't require a conversion at all), and an fp-extend which can be folded into other arithmetic operations.  It probably doesn't make sense to make them use the same API.  That said, the version checking whether an extend is foldable should probably have a different name.


https://reviews.llvm.org/D36706





More information about the llvm-commits mailing list