[PATCH] D38603: Directly return promoted direct call instead of rely on stripPointerCast.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 08:25:21 PDT 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM although I have a question on test



================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:565
 
+  Instruction *CastInst = nullptr;
   Instruction *NewInst =
----------------
Suggest adding a comment above here about what CastInst vs NewInst are for clarity.


================
Comment at: test/Transforms/SampleProfile/indirect-call.ll:100
+; CHECK-LABEL: @return_arg_caller
+; Checks if the promoted indirect call returns a parameter that was returned
+; by the a previous direct call. Both direct call and promoted indirect call
----------------
How is it checking the returned parameter?


https://reviews.llvm.org/D38603





More information about the llvm-commits mailing list